Tim Armstrong has posted comments on this change. Change subject: IMPALA-5644: Reject queries if min reservation is too large ......................................................................
Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/7678/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: Line 401: // Compute the max (over all backends) min_reservation_bytes and the cluster total > Yeah it's a good idea, I started playing around with doing that earlier but Yeah that's true, we do have that in the profile. Would it make sense to refer to that profile line in the error message? Printing the schedule in a human-readable format as part of the explain plan isn't such a crazy idea :). I guess it's not as simple if we ever change the scheduling logic so that it's not a discrete step before admission control. http://gerrit.cloudera.org:8080/#/c/7678/3/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: PS3, Line 332: Nit: don't need space before colon -- To view, visit http://gerrit.cloudera.org:8080/7678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
