Tim Armstrong has posted comments on this change. Change subject: IMPALA-5644: Reject queries if min reservation is too large ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7678/4/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: PS4, Line 153: if (query_options().__isset.buffer_pool_limit : && query_options().buffer_pool_limit > 0) { : max_reservation = query_options().buffer_pool_limit; : } > Question for Tim & Dan: I tend to think of buffer_pool_limit as advanced option to directly override the default buffer pool limit, instead of being an additional constraint. http://gerrit.cloudera.org:8080/#/c/7678/4/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: Line 125: "more information."; > That's right, at least not as we currently think about admission control. I Yeah this overall seemed simplest since at this point we've already resolved the resource pool and figured out the applicable limits. It seemed ok that it would fail later with admission control disabled, since that is an unusual suboptimal configuration. -- To view, visit http://gerrit.cloudera.org:8080/7678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
