Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 ......................................................................
Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/7866/1/be/src/thirdparty/squeasel/squeasel.c File be/src/thirdparty/squeasel/squeasel.c: Line 4259: SSL_CTX_set_options(ctx->ssl_ctx, options); Check the return value of this? if (!(SSL_CTX_set_options(ctx_, options) & options)) { cry() } http://gerrit.cloudera.org:8080/#/c/7866/1/be/src/util/webserver-test.cc File be/src/util/webserver-test.cc: PS1, Line 298: 0x10001000L May be define it as OPENSSL_MIN_VERSION_WITH_TLS_1_1 for readability. -- To view, visit http://gerrit.cloudera.org:8080/7866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20c5d39c0c4ae9c5445dd3ee3b175fe337a5728d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
