Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 ......................................................................
Patch Set 1: (1 comment) An update: I discovered that it is *not* backwards compatible to use the constants SSL_OP_NO_TLSv1_1 or SSL_OP_NO_TLSv1_2 in OpenSSL 1.0.0 because their values were defined as different constants that have since been deprecated. So setting these options actually does *something different*, despite the supposed backwards compatibility between 1.0.1 and 1.0.0. I'll be updating this patch with a fix shortly. http://gerrit.cloudera.org:8080/#/c/7866/1//COMMIT_MSG Commit Message: PS1, Line 24: TODO Toolchain will need a version bump when thrift-0.9.0-p11 is approved. > Can this be removed? Will do. -- To view, visit http://gerrit.cloudera.org:8080/7866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20c5d39c0c4ae9c5445dd3ee3b175fe337a5728d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes