Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7866/1//COMMIT_MSG Commit Message: Line 25: > Could you add in the commit message what kind of error messages to expect w Sorry, missed this. Will do. http://gerrit.cloudera.org:8080/#/c/7866/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS1, Line 185: system OpenSSL > "linked OpenSSL library" for clarity? Should users choose to link it to a n I thought about this, but I think the best thing is to emphasise that OpenSSL comes from the system, not from Impala itself. I agree that, if they play tricks with LD_LIBRARY_PATH, this might not be 100% accurate, but I don't feel that's going to confuse users. -- To view, visit http://gerrit.cloudera.org:8080/7866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20c5d39c0c4ae9c5445dd3ee3b175fe337a5728d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
