Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8216 )
Change subject: IMPALA-6011: Remove use of Guava Hasher. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8216/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8216/1//COMMIT_MSG@15 PS1, Line 15: in the shell. I verified that the new code is executed. It looks like lineage.test verifies the exact value of some query hashes too (wanted to convince myself that that didn't accidentally change). http://gerrit.cloudera.org:8080/#/c/8216/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: http://gerrit.cloudera.org:8080/#/c/8216/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@596 PS1, Line 596: return "Query hash failed"; Seems like this should be a precondition or throw a runtime error or similar (it looked like Guava throws an AssertionError). http://gerrit.cloudera.org:8080/#/c/8216/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@601 PS1, Line 601: // String conversion code taken from Guava's HashCode.toString(). Seems like the string conversion code should be a utility function. Alternatively it looks like commons-codec has a function that does this: https://commons.apache.org/proper/commons-codec/apidocs/org/apache/commons/codec/binary/Hex.html#encodeHexString(byte[]) I guess part of the point was to reduce our dependency on external libraries, but I think Apache commons generally has more stable APIs. -- To view, visit http://gerrit.cloudera.org:8080/8216 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04b8888b436eb93a86b8db24b2a97f14047f828b Gerrit-Change-Number: 8216 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 15:11:30 +0000 Gerrit-HasComments: Yes
