Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8216 )
Change subject: IMPALA-6011: Remove use of Guava Hasher. ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8216/2/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: http://gerrit.cloudera.org:8080/#/c/8216/2/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@318 PS2, Line 318: private final char[] hexDigits_ = "0123456789abcdef".toCharArray(); You can make this static and call it HEX_DIGITS to mark it as a constant? http://gerrit.cloudera.org:8080/#/c/8216/2/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@593 PS2, Line 593: private String getQueryHash(String queryStr) { It's a bit pedantic, but it'd be nice to write a test that executes this code. Ideally, we'd also confirm that some query hashes to the same result as it used to with the Guava implementation. http://gerrit.cloudera.org:8080/#/c/8216/2/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@599 PS2, Line 599: throw new IllegalStateException("Query hash failed"); typically this would be "throw new IllegalStateException("Query hash failed", e)" I think that chains the exceptions, which is handy since we'll want to know what e.getMessage() says. (This will never actually happen, but it's more idiomatic I think.) -- To view, visit http://gerrit.cloudera.org:8080/8216 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04b8888b436eb93a86b8db24b2a97f14047f828b Gerrit-Change-Number: 8216 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 05 Oct 2017 17:48:23 +0000 Gerrit-HasComments: Yes
