Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8216 )
Change subject: IMPALA-6011: Remove use of Guava Hasher. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8216/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8216/1//COMMIT_MSG@15 PS1, Line 15: in the shell. I verified that the new code is executed. > lineage.test is a planner test. It succeeds because we don't compare the qu So we don't have any testing that the query hash is a sensible value? I don't think you broke it but seems like a test coverage gap. http://gerrit.cloudera.org:8080/#/c/8216/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: http://gerrit.cloudera.org:8080/#/c/8216/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@601 PS1, Line 601: // String conversion code taken from Guava's HashCode.toString(). > I bet we are pulling in many versions of Apache commons as well. The API ma I'm still wondering if this should be a separate utility function. It seems ok to have our own version of this but in general that argument about dependencies would justify never using external libraries, which doesn't seem right. -- To view, visit http://gerrit.cloudera.org:8080/8216 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04b8888b436eb93a86b8db24b2a97f14047f828b Gerrit-Change-Number: 8216 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 17:47:36 +0000 Gerrit-HasComments: Yes
