Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8216 )
Change subject: IMPALA-6011: Remove use of Guava Hasher. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8216/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: http://gerrit.cloudera.org:8080/#/c/8216/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@602 PS1, Line 602: final char[] hexDigits = "0123456789abcdef".toCharArray(); nit: I would have expected this to be a class constant class Vertex { private static final char[] hexDigits = ...; ... } -- To view, visit http://gerrit.cloudera.org:8080/8216 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04b8888b436eb93a86b8db24b2a97f14047f828b Gerrit-Change-Number: 8216 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 15:59:32 +0000 Gerrit-HasComments: Yes
