Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 )
Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/rpc/authentication.cc@77 PS6, Line 77: "Only used when FLAGS_use_krpc is false"); > in what case would a user need to set this flag? and how is that case handl Currently all our users use this flag. This needs to be set when we use our current way of forking kinit (i.e. in other words when FLAGS_use_krpc is false, in the context of this patch), since our RunKinit() function uses that to periodically wake up. I'm not sure of the history of this flag, but it is a completely unnecessary flag. Our reinit interval should be based on the configured ticket lifetime in the system's krb5.conf file, which is what we've done in the kudu kinit case. It detects this ticket lifetime and wakes up periodically according to that to do the reinit. Allowing a user to control this flag is very redundant and possibly confusing to users that understand kerberos. -- To view, visit http://gerrit.cloudera.org:8080/7938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7 Gerrit-Change-Number: 7938 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 10 Oct 2017 18:43:06 +0000 Gerrit-HasComments: Yes
