Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 )
Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/7938/7/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: http://gerrit.cloudera.org:8080/#/c/7938/7/be/src/rpc/thrift-server-test.cc@96 PS7, Line 96: static int kdc_port = GetServerPort(); > static Done http://gerrit.cloudera.org:8080/#/c/7938/7/be/src/rpc/thrift-server-test.cc@247 PS7, Line 247: } > As discussed offline, may be it'd help to test with short renewal period to This makes the test infra quite flakey. I tried for quite some time, but it seems as though starting many KDCs close to each other with different configurations seems to be problematic. I'm not sure why yet though. It is a test infra issue rather than a functional kerberos issue. I think it will be better if I took time later to see what the problem could be and add the test in a separate patch to save some time. -- To view, visit http://gerrit.cloudera.org:8080/7938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7 Gerrit-Change-Number: 7938 Gerrit-PatchSet: 8 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Fri, 13 Oct 2017 05:38:23 +0000 Gerrit-HasComments: Yes
