Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 )
Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/rpc/authentication.cc@77 PS6, Line 77: "Only used when FLAGS_use_krpc is false"); > Currently all our users use this flag. This needs to be set when we use our Okay. So in other words, we could have fixed the old code as well, and eliminated this flag in that case. (Let's not bother with that though, given we will rip that code out soon). -- To view, visit http://gerrit.cloudera.org:8080/7938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7 Gerrit-Change-Number: 7938 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 10 Oct 2017 18:45:15 +0000 Gerrit-HasComments: Yes
