Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 )
Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/exec/kudu-util.h File be/src/exec/kudu-util.h: http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/exec/kudu-util.h@45 PS6, Line 45: (FromKuduStatus(status)) > nit: parenthesis not needed. Done http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/rpc/auth-provider.h File be/src/rpc/auth-provider.h: http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/rpc/auth-provider.h@144 PS6, Line 144: forks > nit: forks Impalad and exec 'kinit' Done http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/rpc/authentication.cc@77 PS6, Line 77: "Only used when FLAGS_use_krpc is false"); > Okay. So in other words, we could have fixed the old code as well, and elim Yes, we could have, but we couldn't deprecate this flag in a minor release anyway, so I never went ahead with it. http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: http://gerrit.cloudera.org:8080/#/c/7938/6/be/src/rpc/thrift-server-test.cc@117 PS6, Line 117: !(GetParam() == USE_KUDU_KERBEROS) > Did you flip the polarity ? Oops, I did that for some local testing verification and forgot to turn it back. Switched it back. -- To view, visit http://gerrit.cloudera.org:8080/7938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7 Gerrit-Change-Number: 7938 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Wed, 11 Oct 2017 05:33:37 +0000 Gerrit-HasComments: Yes
