Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 )
Change subject: Allow the SASL protocol service name to be configurable ...................................................................... Patch Set 1: (2 comments) > Is this a conflict free cherry-pick from something already in Kudu > codebase? Yes this is a cherry-pick from the following kudu commit: https://github.com/apache/kudu/commit/31d58522b50aea948f977c7cbc8b64f1b849f323 There were a couple of conflicts, but with simple resolutions. http://gerrit.cloudera.org:8080/#/c/8230/1/be/src/kudu/rpc/client_negotiation.cc File be/src/kudu/rpc/client_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8230/1/be/src/kudu/rpc/client_negotiation.cc@111 PS1, Line 111: const boost::optional<security::SignedTokenPB>& authn_token, There was a conflict here since we don't have this patch from the kudu code base: https://github.com/apache/kudu/commit/50c7d3249ab5ca19fb4d3c0c8748a4a1c5945a12#diff-ced439e8f22cae7f007af6cb1daf945a The above patch changes removes the const ref on this variable. But the resolution was simple. http://gerrit.cloudera.org:8080/#/c/8230/1/be/src/kudu/rpc/server_negotiation.cc File be/src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8230/1/be/src/kudu/rpc/server_negotiation.cc@128 PS1, Line 128: const security::TokenVerifier* token_verifier, Similarly, there was a conflict here since we don't have that same patch from the kudu code base: https://github.com/apache/kudu/commit/50c7d3249ab5ca19fb4d3c0c8748a4a1c5945a12#diff-ced439e8f22cae7f007af6cb1daf945a The above patch changes removes the const ref on this variable. But the resolution was simple. -- To view, visit http://gerrit.cloudera.org:8080/8230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e30fe4461893b67527333259579e2304b19af1e Gerrit-Change-Number: 8230 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Wed, 11 Oct 2017 17:54:14 +0000 Gerrit-HasComments: Yes
