Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 )
Change subject: Allow the SASL protocol service name to be configurable ...................................................................... Patch Set 2: > (1 comment) I tried cherry-picking: https://github.com/apache/kudu/commit/50c7d3249ab5ca19fb4d3c0c8748a4a1c5945a12 But since it touches so many files, it doesn't cherry-pick cleanly and adds some extra code from patches that we don't have in our code base, due to how the diff was generated. Also, it incorrectly modifies out .clang-tidy file since Kudu's .clang tidy does not exist in our fetch of their code. Also, the 3 way merge gets confused and ends up modifying our gutil/bind_internal.h instead of their kudu/gutil/bind_internal.h. We can resolve all this manually, but I think it's a bit too risky. -- To view, visit http://gerrit.cloudera.org:8080/8230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e30fe4461893b67527333259579e2304b19af1e Gerrit-Change-Number: 8230 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Wed, 18 Oct 2017 04:45:09 +0000 Gerrit-HasComments: No
