Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 )
Change subject: Allow the SASL protocol service name to be configurable ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8230/1/be/src/kudu/rpc/client_negotiation.cc File be/src/kudu/rpc/client_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8230/1/be/src/kudu/rpc/client_negotiation.cc@111 PS1, Line 111: const boost::optional<security::SignedTokenPB>& authn_token, > Should we just take that patch to make (this and) future cherry picks easie That patch is a tidy cleanup that adds the 'modernize-pass-by-value' rule, which we don't use ourselves. Looking over the patch, it looks like not having it could cause a few more conflicts, but they can all be trivially resolved just as I did here. Also, we will keep running into this issue of cherry-picked patches that conflict due to not having the entire history. So it's something we need to solve on a case by case basis. My take is, let's only cherry-pick the patches that we really need. So as for this patch, since it doesn't help us a lot, I think we can leave it out. -- To view, visit http://gerrit.cloudera.org:8080/8230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e30fe4461893b67527333259579e2304b19af1e Gerrit-Change-Number: 8230 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Wed, 11 Oct 2017 18:12:20 +0000 Gerrit-HasComments: Yes
