Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 )
Change subject: Allow the SASL protocol service name to be configurable ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8230/1/be/src/kudu/rpc/client_negotiation.cc File be/src/kudu/rpc/client_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8230/1/be/src/kudu/rpc/client_negotiation.cc@111 PS1, Line 111: const boost::optional<security::SignedTokenPB>& authn_token, > That patch is a tidy cleanup that adds the 'modernize-pass-by-value' rule, It seems better to also cherry-pick that particular commit so we avoid the chances of other conflicts in the future. That commit seems to touch some number of files under rpc/ security/ and util/. -- To view, visit http://gerrit.cloudera.org:8080/8230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e30fe4461893b67527333259579e2304b19af1e Gerrit-Change-Number: 8230 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Sat, 14 Oct 2017 01:04:30 +0000 Gerrit-HasComments: Yes
