Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 )
Change subject: IMPALA-5142 EventSequence displays negative elapsed time. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8215/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8215/1//COMMIT_MSG@22 PS1, Line 22: value. > but the code isn't synchronized at all, so you could (in theory) read a gar That's right since the code not synchronized we can read a garbage start_ which is the case here.I was wondering wether there will be performance overhead if lock is used to seialize. So instead of printing a negative value I'm printing 0. The Start() is called from ClientRequestState() ClientRequestState::ClientRequestState() { query_events_ = summary_profile_->AddEventSequence("Query Timeline");··················· query_events_->Start(); } whereas ElapsedTime() RuntimeProfile::EventSequence::MarkEvent() { sw_.ElapsedTime(); } -- To view, visit http://gerrit.cloudera.org:8080/8215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c944396d96473b17b453da3e913ffc56680a896 Gerrit-Change-Number: 8215 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Tue, 17 Oct 2017 03:48:03 +0000 Gerrit-HasComments: Yes
