Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 )
Change subject: IMPALA-5142 EventSequence displays negative elapsed time. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8215/2/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/8215/2/be/src/util/runtime-profile.cc@658 PS2, Line 658: event_sequence.second->GetEvents(&events); : if (last == 0 && events.size() > 0) last = events.back().second; > that looks like it could be inconsistent with the sorted order Introduced a fix to check and fix the event order in event list in GetEvents() http://gerrit.cloudera.org:8080/#/c/8215/2/be/src/util/runtime-profile.cc@672 PS2, Line 672: > runtime-profile-test.cc has a test case that expects GetEvents() to be in o The events are printed in the list order and as they are printed the value of current is decremented from previous to get the elapsed time. So we are getting a list of events that are not in order. I've moved the sorting code in GetEvents() as per your suggestion which seems to be more plausible. -- To view, visit http://gerrit.cloudera.org:8080/8215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c944396d96473b17b453da3e913ffc56680a896 Gerrit-Change-Number: 8215 Gerrit-PatchSet: 2 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Wed, 25 Oct 2017 18:33:36 +0000 Gerrit-HasComments: Yes
