Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8215
to look at the new patch set (#2).
Change subject: IMPALA-5142 EventSequence displays negative elapsed time.
......................................................................
IMPALA-5142 EventSequence displays negative elapsed time.
EventSequence::EventList which stores the Event in increasing time order may
have
at times Events that are not stored in increasing time order. This may happen
when
concurrently EventSequence::MarkEvent() is called for different Events in the
same
EventSequence.
The incorrect time order of Event in EventList results in a negative value being
displayed, which is the issue reported in this JIRA.
The issue can be fixed either be re-ordering the lock in
EventSequence::MarkEvent()
or by sorting the EventList before printing. This patch fixes the issue by
sorting the EventList before printing.Since reordering the lock in
EventSequence::MarkEvent() will involve holding the lock across clock_gettime().
Testing:
Ran all the front-end/backend and end-end tests.
Change-Id: I8c944396d96473b17b453da3e913ffc56680a896
---
M be/src/util/runtime-profile.cc
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/8215/2
--
To view, visit http://gerrit.cloudera.org:8080/8215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c944396d96473b17b453da3e913ffc56680a896
Gerrit-Change-Number: 8215
Gerrit-PatchSet: 2
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Pranay Singh
