Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 )
Change subject: IMPALA-5142 EventSequence displays negative elapsed time. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8215/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8215/1//COMMIT_MSG@22 PS1, Line 22: value. > In the thread doing ClientRequestState::ClientRequestState() There is only one call to AddEventSequence("Query Timeline") per query though, right? so how does another thread operate on that event_sequence_ before the constructor of CRS() returns? Are you able to reproduce this problem? If so, can you change your if-stmt to a DCHECK() and put the backtrace in the JIRA when the DCHECK fires. -- To view, visit http://gerrit.cloudera.org:8080/8215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c944396d96473b17b453da3e913ffc56680a896 Gerrit-Change-Number: 8215 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Tue, 17 Oct 2017 23:30:42 +0000 Gerrit-HasComments: Yes
