Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 )
Change subject: IMPALA-5736: Add impala-shell argument to set default query options ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/8038/9/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8038/9/shell/impala_shell.py@688 PS9, Line 688: > Nit: trailing white space. You can use 'git diff --check' to catch these. Done http://gerrit.cloudera.org:8080/#/c/8038/7/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/8038/7/shell/option_parser.py@58 PS7, Line 58: return config_filename > As discussed in person, can you please add a test for this case? It turned out, that there is already a test for this branch (test_shell_commandline.py / test_config_file), but I did not run it... Running test_shell_commandline.py revealed that there was another issue caused by this change: breaking execute_queries_non_interactive_mode(), which handles the case when -q option is set). This issue was fixed in the new patch. -- To view, visit http://gerrit.cloudera.org:8080/8038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986 Gerrit-Change-Number: 8038 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Fri, 20 Oct 2017 19:28:28 +0000 Gerrit-HasComments: Yes
