Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 )
Change subject: IMPALA-5736: Add impala-shell argument to set default query options ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/8038/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8038/14//COMMIT_MSG@30 PS14, Line 30: > This seems to lack a _ Done http://gerrit.cloudera.org:8080/#/c/8038/14/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/8038/14/tests/shell/test_shell_commandline.py@389 PS14, Line 389: formatting > This does not report a formatting error, so I'm inclined to remove the "Che This part was printed by impala_shell.py, which did not differentiate between different exceptions from config_parser. I wanted to keep it this way, so I have added some exceptions that format the full error message. -- To view, visit http://gerrit.cloudera.org:8080/8038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986 Gerrit-Change-Number: 8038 Gerrit-PatchSet: 14 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Wed, 25 Oct 2017 15:48:04 +0000 Gerrit-HasComments: Yes
