Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 )
Change subject: IMPALA-5736: Add impala-shell argument to set default query options ...................................................................... Patch Set 14: (3 comments) Sorry for the many patches, 12, 13, 14 should be seen as one. There are also some functional changes (see commit message), and automatic tests were added for some impalarc related warnings/errors. http://gerrit.cloudera.org:8080/#/c/8038/11/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/8038/11/shell/option_parser.py@36 PS11, Line 36: parse_bool_option(value): > I still struggle to understand the function name. How about parse_shell_opt I have rewritten these functions again, I hope that the naming is more intuitive in the new version. http://gerrit.cloudera.org:8080/#/c/8038/11/shell/option_parser.py@37 PS11, Line 37: """Returns True for '1' and 'True', and False for '0' and 'False'. > Mention that this parses string values into corresponding python types. The Done http://gerrit.cloudera.org:8080/#/c/8038/11/shell/option_parser.py@64 PS11, Line 64: > types Done -- To view, visit http://gerrit.cloudera.org:8080/8038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986 Gerrit-Change-Number: 8038 Gerrit-PatchSet: 14 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Tue, 24 Oct 2017 15:43:13 +0000 Gerrit-HasComments: Yes
