Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 )
Change subject: IMPALA-5736: Add impala-shell argument to set default query options ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/8038/11/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/8038/11/shell/option_parser.py@36 PS11, Line 36: convert_loaded_shell_option I still struggle to understand the function name. How about parse_shell_option(option, default_value). http://gerrit.cloudera.org:8080/#/c/8038/11/shell/option_parser.py@37 PS11, Line 37: """Converts values 'True', 'False' and 'None' to their corresponding python values. Mention that this parses string values into corresponding python types. The comment should also explain what happens if the parsing fails. http://gerrit.cloudera.org:8080/#/c/8038/11/shell/option_parser.py@64 PS11, Line 64: values types -- To view, visit http://gerrit.cloudera.org:8080/8038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986 Gerrit-Change-Number: 8038 Gerrit-PatchSet: 11 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Fri, 20 Oct 2017 22:50:35 +0000 Gerrit-HasComments: Yes
