Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 )
Change subject: IMPALA-5564: Release lock during planning. (wip) ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8434/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8434/1//COMMIT_MSG@17 PS1, Line 17: whereas the web UI would previously block on the lock. After IMPALA-1972, it doesn't block, it just returns an empty profile. http://gerrit.cloudera.org:8080/#/c/8434/1//COMMIT_MSG@26 PS1, Line 26: know the query id : that's necessary to call GetResultSetMetadata() It looks to me like this is against IMPALA-2568. I guess we eventually want to make ExecuteStatement() async, rather than blocking on planning/metadata load. We already hit that problem with clients like Hue timing out while loading metadata for large tables. If we eventually want to move in that direction, I think these changes need to be undone then. -- To view, visit http://gerrit.cloudera.org:8080/8434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e3fc4c28d7a5ad8546d48bcd22c03fbce502e5b Gerrit-Change-Number: 8434 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 31 Oct 2017 23:42:20 +0000 Gerrit-HasComments: Yes
