Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 )
Change subject: IMPALA-5564: Release lock during planning. (wip) ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8434/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8434/1//COMMIT_MSG@17 PS1, Line 17: whereas the web UI would previously block on the lock. > Looking over https://gerrit.cloudera.org/c/6707/12/be/src/service/impala-se Yep, we take the lock if the query is not in a CREATED state. -- Status ImpalaServer::GetRuntimeProfileStr(const TUniqueId& query_id, const string& user, bool base64_encoded, stringstream* output) { DCHECK(output != nullptr); // Search for the query id in the active query map { shared_ptr<ClientRequestState> request_state = GetClientRequestState(query_id); if (request_state.get() != nullptr) { // For queries in CREATED state, the profile information isn't populated yet. if (request_state->query_state() == beeswax::QueryState::CREATED) { return Status::Expected("Query plan is not ready."); } lock_guard<mutex> l(*request_state->lock()); -- I agree this is a very important change from a usability/supportability perspective, to have a partial profile visible to the user. http://gerrit.cloudera.org:8080/#/c/8434/1//COMMIT_MSG@26 PS1, Line 26: know the query id : that's necessary to call GetResultSetMetadata() > Yes, IMPALA-2568 is one of the eventual goals. This is actually listed as t I was thinking more along the "profile copy" path Dan suggested, so that we can avoid removing the lock during planning. I thought the latter involved more work since it could affect cancellations. With the current patch, cancellations don't block anymore. when the query is planning, so I think we should make sure to get that part right. I'm fine with this approach, if the cancellation works without any issues. -- To view, visit http://gerrit.cloudera.org:8080/8434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e3fc4c28d7a5ad8546d48bcd22c03fbce502e5b Gerrit-Change-Number: 8434 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 01 Nov 2017 18:41:16 +0000 Gerrit-HasComments: Yes
