Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 )
Change subject: IMPALA-5564: Release lock during planning. (wip) ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8434/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8434/1//COMMIT_MSG@17 PS1, Line 17: whereas the web UI would previously block on the lock. > After IMPALA-1972, it doesn't block, it just returns an empty profile. I tried this out (admittedly 1.5 weeks ago, but I don't think it's changed). You can go to the web UI and see the queries, but if you click on "Profile", you'll get stuck getting the lock in ImpalaServer::GetRuntimeProfileStr() below. Am I missing something? Status ImpalaServer::GetRuntimeProfileStr(const TUniqueId& query_id, const string& user, bool base64_encoded, stringstream* output) { DCHECK(output != nullptr); // Search for the query id in the active query map { shared_ptr<ClientRequestState> request_state = GetClientRequestState(query_id); if (request_state.get() != nullptr) { lock_guard<mutex> l(*request_state->lock()); http://gerrit.cloudera.org:8080/#/c/8434/1//COMMIT_MSG@26 PS1, Line 26: know the query id : that's necessary to call GetResultSetMetadata() > It looks to me like this is against IMPALA-2568. I guess we eventually want Yes, IMPALA-2568 is one of the eventual goals. This is actually listed as the first subtask of that JIRA. It's easier to argue that this one is compatible. As for this one needing to be undone, it's hard to say. I think you solve IMPALA-2568 by having more fine-grained and clear query states/lifecycles. I think this is a step in that direction. What would you suggest? -- To view, visit http://gerrit.cloudera.org:8080/8434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e3fc4c28d7a5ad8546d48bcd22c03fbce502e5b Gerrit-Change-Number: 8434 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 01 Nov 2017 15:32:48 +0000 Gerrit-HasComments: Yes
