Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 )
Change subject: IMPALA-5564: Release lock during planning. (wip) ...................................................................... Patch Set 1: (2 comments) I think this path is worth continuing down. The alternate solution would be to have a profile copy that can be returned before the actual profile is ready, but if releasing the lock works out, that seems simplest. We should check how this minimal profile looks in CM -- there might be some other fields that they require? http://gerrit.cloudera.org:8080/#/c/8434/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8434/1//COMMIT_MSG@17 PS1, Line 17: whereas the web UI would previously block on the lock. > Looking over https://gerrit.cloudera.org/c/6707/12/be/src/service/impala-se Right, this JIRA is a follow up to 1972 to improve things further so that the (partial) query profile can be retrieved. http://gerrit.cloudera.org:8080/#/c/8434/1/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/8434/1/be/src/service/client-request-state.h@342 PS1, Line 342: is_planning_ maybe make that is_planning_finished_ (or similar), and initialize it to false and just set to true after planning? Actually, since the goal is to guard against other RPCs to execute until the handle is returned, maybe just make it is_execute_stmt_finished? -- To view, visit http://gerrit.cloudera.org:8080/8434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e3fc4c28d7a5ad8546d48bcd22c03fbce502e5b Gerrit-Change-Number: 8434 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 01 Nov 2017 17:54:17 +0000 Gerrit-HasComments: Yes
