Caideyipi commented on PR #19031:
URL: https://github.com/apache/iotdb/pull/19031#issuecomment-6443377275

   Independent re-review of PR #19031 at head 
`2577a568196312f83544206125eb691f1eed65a3` found no actionable issues; no fixes 
were needed.
   
   I inspected the complete five-file diff and the related LOAD snapshot, 
progress-log recovery, writer reconstruction, restore, and copy-isolation call 
chains. The new snapshot finalization removes only copied staged TsFiles whose 
repaired progress log has no complete chunk record, removes their copied 
sidecars, and leaves the source task files untouched. The earlier 
independent-copy fix remains effective, and the directory-scan catch-up path 
now supplies a copied data file when the progress log appears between scans. No 
regression was found in the interaction among recovery, torn-log repair, 
snapshot cleanup, or later piece appends.
   
   Verification at the reviewed head:
   
   - `git diff --check` passed.
   - A clean JDK 17 serial dependency reactor on `192.168.130.6` used fresh 
source and Maven-repository directories with `-Ddevelocity.off=true`. 
`LoadTsFileProgressTest` ran 10 tests with 0 failures/errors, and 
`LoadTsFileSnapshotTest` ran 14 tests with 0 failures/errors; all 24 passed, 
including the 10 newly added tests.
   - The targeted `ClusterIT` reactor ran 
`IoTDBLoadTsFileClusterIT#testRestartedDataNodeIsSyncedWithTheLoadedFile` and 
`#testLoadAfterOneDataNodeDown`: 2 tests, 0 failures, 0 errors.
   - An earlier parallel reactor attempt stopped before tests because the 
Thrift generator reported `Text file busy`; it is not counted as a passing or 
failing test result.
   
   The PR was still draft during this review, and the remote head matched the 
reviewed revision before this comment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to