Caideyipi commented on PR #19031: URL: https://github.com/apache/iotdb/pull/19031#issuecomment-6440537074
Initial self-review found and fixed one actionable issue in d5766d7e593363ec14a6c9ce0f4c04b446e7a17d. `publishAtomicCopy` preferred hard links for writable staging files and progress logs. A snapshot's torn-header or torn-entry repair could therefore truncate the live source log, and later LOAD pieces could change an already completed snapshot. Snapshot/restore publication now uses independent copies. Three deterministic regressions cover both source-log preservation cases and snapshot stability after a subsequent piece. The concurrency is between the Region migration snapshot and LOAD application: the snapshot path does not acquire the consensus write lock, even when the pieces of one LOAD are applied sequentially. Verification: local Spotless passed. A clean JDK 17 dependency-reactor build on `192.168.130.6`, with a fresh Maven repository and build-output caching disabled, rebuilt all 28 modules and passed all 77 selected LOAD tests. All three new isolation regressions failed with the preceding hard-link implementation and passed with the fix. The local Windows reactor attempt was blocked by its commit limit, and an earlier remote attempt was blocked by dependency-repository connectivity; neither is reported as passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
