Caideyipi commented on PR #19031:
URL: https://github.com/apache/iotdb/pull/19031#issuecomment-6458978782

   Review scope for fix commit `8197477129420d71c0a9457d8d345eb3d5269422`:
   
   The reported failure was 
`LoadTsFileSnapshotTest.testSnapshotTakenWhilePiecesAreAppliedStaysRestorable` 
on Windows: the writer future failed with `java.io.FileNotFoundException` while 
the snapshot copied a live staged TsFile. This commit changes only 
`LoadTsFileSnapshot.publishAtomicCopy` to copy through a shared-read 
`FileChannel`, while retaining the temporary-file and atomic-publication 
behavior.
   
   Please determine whether this fix is behaviorally coupled to the other 
changes in PR #19031, especially the snapshot race/isolation changes in 
`7dbc541` and `d5766d7`. It is intended as a platform-specific fix for the 
concurrent snapshot path; the cluster-test stabilization and progress-log 
recovery changes should be independent. If the fix is independent, review only 
commit `8197477129420d71c0a9457d8d345eb3d5269422` and do not re-review the 
other PR changes. If it is coupled, identify the exact affected interactions 
and review only those related hunks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to