Caideyipi commented on PR #19031:
URL: https://github.com/apache/iotdb/pull/19031#issuecomment-6462921694

   Self-review follow-up for PR #19031 at head 
`0927eac90ad68ca78248d2c8d8b93e959f5e855b` found one actionable test-logic 
issue in the concurrent snapshot regression and fixed it in that commit.
   
   The previous test only observed snapshot growth across independently 
completed writes; it did not force a snapshot to overlap bytes written before 
the corresponding progress record. The test now pauses `setChunkPayloadRefs` 
after the staged bytes are written, takes the snapshot in that window, restores 
it, and replays the paused chunk. It asserts that the restored progress log 
advances from one record to two and keeps writer, latch, and configuration 
cleanup bounded.
   
   Production review of the final five-file PR diff and the related LOAD 
snapshot, progress-log recovery, writer reconstruction, restore, and 
copy-isolation paths found no additional actionable issues.
   
   Verification at the final local commit:
   
   - `mvn spotless:apply -P with-integration-tests -pl iotdb-core/datanode` 
passed.
   - A clean offline JDK 17 dependency reactor with a dedicated Maven 
repository and build-output caches disabled rebuilt all 28 modules from source. 
`LoadTsFileSnapshotTest#testSnapshotTakenWhilePiecesAreAppliedStaysRestorable` 
ran with 1 test, 0 failures, and 0 errors.
   - `git diff --check` passed.
   - The remote head was verified as 
`0927eac90ad68ca78248d2c8d8b93e959f5e855b`; the PR remains open and draft.
   
   The PR remains draft. A fresh independent review is required at the updated 
head.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to