Caideyipi commented on PR #19136: URL: https://github.com/apache/iotdb/pull/19136#issuecomment-6653588322
Independent re-review, one round. Reviewed the complete seven-file diff at `bf65545e4252945454f78c6febf008cc5e8bbe65` against the specified base `e92ecf1d5d62de0c67a52e80ff6cb7e307ab6583`, including the installation/recovery commit boundary, both mods formats, source cleanup, cached handles and metrics, debugger reliability, readiness/isolation, and file/value/null/deletion assertions. The advanced master branch was not merged or rebased into this change. - **P2 fixed:** [mods were counted before atomic publication](https://github.com/apache/iotdb/blob/bf65545e4252945454f78c6febf008cc5e8bbe65/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java#L4933). A failed publication, or a legacy conversion that fails after creating its output, rolls back by deleting staging files without undoing `FileMetrics`. Repeated failed LOAD attempts therefore inflate mods count and size. Installation now converts legacy mods without recording metrics and registers exactly one target handle only after publication. Cached source handles are still replaced; the existing recovery conversion API keeps its default metric behavior. The additional helper change is limited to `TsFileResource`. - The existing source-policy regression now also rejects publication with both mods formats and injects a legacy-conversion completion error. It verifies unchanged metrics after failure, source bytes/sidecars, rollback, and the subsequent successful installation, alongside the existing six source-policy/mods combinations and exact successful count/size assertions. - **Deferred, unchanged P2:** [the load limiter](https://github.com/apache/iotdb/blob/079c9e0a61e4d701ec5ee3722dfa114f4ed5762f/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java#L4867) reads the destination length before creation and can charge zero bytes. This predates the PR and was left unchanged as requested. Validation on Windows, JDK 17.0.15 / Maven 3.8.8: - Clean required-source reactor: all 37 modules and node templates passed (exit 0, 4m37s). The expanded source-policy unit method passed with zero failures/errors/skips. The reactor's fixed CLI environment-script execution also passed, separately from the selected unit count. - Three existing synchronous/asynchronous conversion unit tests passed with zero failures/errors/skips, checking the default API behavior. - Exact Failsafe selection passed: two affected crash methods, eight policy/mods combinations, zero failures/errors/skips. Surefire was explicitly suppressed with a nonexistent class. The node template DataNode JAR matched the newly built artifact by SHA256. - Spotless and whitespace checks passed. IT discovery, categories, and selection were unchanged, so prior Git Bash selection evidence and unaffected test passes were retained. All newly added tests have been executed locally and ultimately passed. No build or test failed in this round. RAT and Enforcer were skipped. External TsFile and transitive snapshot binaries were not rebuilt or fully source-traced. The full suite and zh reactor were not run; remote CI was not verified or awaited. These tests cover process crashes, not machine power loss. Final local HEAD = confirmed source-branch head = confirmed PR head: `079c9e0a61e4d701ec5ee3722dfa114f4ed5762f`. Worktree clean. The PR remains **Draft**, as requested. This behavioral finding requires a fresh independent session; no second review round was performed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
