Caideyipi commented on PR #19136: URL: https://github.com/apache/iotdb/pull/19136#issuecomment-6676396449
Incremental re-review (one round). Reviewed `0871f7080b248a8f9b3f66998d63d6b51ad08508` relative to its direct parent `23a8ec1776d4550883794bd2014730834c164edc`: the complete one-file `LoadTsFileNodeTest` increment and the cleanup, retry, sidecar-path, constructor and caller context needed to assess it. The conclusion covers this increment only. **No actionable in-scope findings; no fixes were needed.** - **Source deletion failure:** a non-empty directory deterministically makes the source deletion fail through all retries. The test requires the source path to remain and all three sidecars (`.resource`, `.mods2`, `.mods`) to remain regular files. These assertions detect accidental sidecar cleanup after the source deletion fails. - **Sidecar deletion failure:** the source is a regular file, while the resource sidecar is a non-empty directory. The test requires the source to be deleted, the failed resource directory and its child to remain, and both mods files to be deleted. This detects cleanup stopping at the resource failure, including a shared try/catch or an early return. Unique temporary directories and finally-block cleanup keep the cases isolated. Verification: the incremental `git diff --check` passed in this round. Existing results supplied for the reviewed SHA report passing Spotless, clean DataNode compilation and five focused tests, with zero failures/errors/skips. All added or modified tests had already been run locally. With no code changes or new verification gap, these checks were not rerun. The full suite and zh build were not run; remote CI was not inspected or awaited. Final local HEAD = confirmed source-branch head = confirmed PR head: `0871f7080b248a8f9b3f66998d63d6b51ad08508`. The worktree is clean; no commit or push was necessary. The PR remains **Draft**, as requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
