Caideyipi commented on PR #19136: URL: https://github.com/apache/iotdb/pull/19136#issuecomment-6653107000
Independent re-review, one round. Reviewed the complete seven-file diff at `e185fb836b69aa6917d79dbd92362bf72445a2fc` against `e92ecf1d5d62de0c67a52e80ff6cb7e307ab6583`, including installation/recovery, source cleanup, cached mods handles, JDI boundaries, readiness/isolation, and the file/value/null/deletion assertions. - **P2 fixed:** [the legacy mods cache rebinding](https://github.com/apache/iotdb/blob/e185fb836b69aa6917d79dbd92362bf72445a2fc/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java#L5003) counted the installed mods twice. Synchronous conversion already records its target handle in `FileMetrics`; constructing another metrics-recording handle doubled file count and size, leaving residual counts after removal. The fix reuses the conversion result while discarding a cached source handle. The source-policy unit regression now covers retain/delete with no, legacy, and modern mods, with exact count/size increments and installed-handle/deletion checks. - **Deferred, unchanged P2:** [the load limiter](https://github.com/apache/iotdb/blob/bf65545e4252945454f78c6febf008cc5e8bbe65/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java#L4867) reads the destination length before its creation and can charge zero bytes. This predates this PR and remains outside this repair. Validation passed locally on Windows with JDK 17.0.15 and Maven 3.8.8: - A clean required-source reactor rebuilt all 37 required IoTDB modules and node templates. The selected unit method passed all six combinations, with zero failures/errors/skips. The reactor's fixed CLI environment-script execution also passed. - Targeted Failsafe verification ran exactly two affected crash methods (after mods installation/before publication, and after publication/before acknowledgement), eight combinations, with zero failures/errors/skips. Surefire was explicitly suppressed. The node template DataNode JAR matched the newly built JAR by SHA256. - Spotless and the final staged whitespace check passed. IT discovery/categories were unchanged; prior selection evidence and unaffected test passes were retained. All newly added tests have been executed locally. RAT and Enforcer were skipped. Published TsFile binaries were reused and were not rebuilt or fully source-traced. The full suite and zh-locale reactor were not run; remote CI was not inspected or awaited. This validates process crashes; power-loss durability was not tested. Final local HEAD, confirmed source-branch head, and PR head are all `bf65545e4252945454f78c6febf008cc5e8bbe65`. The worktree is clean. PR remains **Draft** as requested. This behavioral finding requires a fresh independent session; no second review round was performed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
