Caideyipi commented on PR #19136: URL: https://github.com/apache/iotdb/pull/19136#issuecomment-6653818186
Independent re-review, round 4 (one round). Reviewed the complete eight-file diff at `079c9e0a61e4d701ec5ee3722dfa114f4ed5762f` against the specified base `e92ecf1d5d62de0c67a52e80ff6cb7e307ab6583` and relevant production/test context. The advanced master branch was not merged or rebased into this change. **No new actionable in-scope findings; no fixes were needed.** Coverage included staging and recovery, resource and both mods formats, atomic publication and failure cleanup, source policies and cached handles, metric registration, the new `TsFileResource` conversion overload/future and existing recovery defaults, JDI reliability, all three crash windows, outstanding requests versus committed installations and explicit new submissions, exact file/value/null/deletion assertions, Region readiness and isolation. The latest failed-publication/conversion regression's injection, assertions and cleanup were also reviewed. The separately tracked #19141 issue and #19128 were excluded as requested. Verification in this round was read-only: all eight source hashes matched the recorded final build manifest, and the fixed-base whitespace check passed. Retained final XML was inspected for actual method selection and zero failures/errors/skips, including the latest source-policy/default-conversion tests and affected crash ITs. IT reports confirm Failsafe `-Dit.test` selection and explicit Surefire suppression. All newly added tests had already been executed locally and ultimately passed. With unchanged code and no uncovered verification gap, builds and tests were not repeated; these are existing execution results, not new passes in this round. Existing limits remain: the full suite and full zh reactor were not run; remote CI was not independently verified or awaited. Recorded builds skipped RAT/Enforcer and used external TsFile/transitive snapshot binaries that were not rebuilt or fully source-traced. The evidence covers process crashes, not machine power loss. Final local HEAD = confirmed source-branch head = confirmed PR head: `079c9e0a61e4d701ec5ee3722dfa114f4ed5762f`. Worktree clean. No commit or push was necessary. The PR remains **Draft** under the explicit request; no ready transition or second review round was performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
