Caideyipi opened a new pull request, #19323:
URL: https://github.com/apache/iotdb/pull/19323

   The table failure assertion helpers execute a statement but discard its 
ResultSet without advancing it. If a query returns initial rows and reports an 
execution error only when a later result batch is fetched, the helper currently 
reaches `No exception!` instead of checking the expected message.
   
   This change drains and closes the ResultSet in both table 
`tableAssertTestFail` overloads. SQLExceptions raised during execution or 
iteration are checked against the expected message.
   
   Example: `SELECT approx_count_distinct(province, 0.3) FROM table1` expects 
`750: Max Standard Error must be in [0.0040625, 0.26]: 0.3`. This range 
validation currently occurs while producing the initial response; the helper 
change also covers failures surfaced by later `ResultSet.next()` fetches.
   
   Validation: `mvn clean verify -DskipUTs 
-Dit.test=IoTDBTableAggregationIT#exceptionTest -DfailIfNoTests=false 
-Dfailsafe.failIfNoSpecifiedTests=false -pl integration-test -am 
-PTableSimpleIT -P with-integration-tests` (1 test passed, no failures or 
skips).
   
   Coverage note: The focused test does not force an error that occurs only on 
a later fetch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to