Caideyipi commented on PR #19323:
URL: https://github.com/apache/iotdb/pull/19323#issuecomment-6999890961

   Independent re-review summary for PR #19323.
   
   Reviewed the complete diff from base 
0002b377a0b059ed890b2635a5a21c649a039a10 through head 
637382308a23e770ed57ca082651094b7160f6af. No actionable findings; no fixes were 
needed.
   
   - Drain behavior: assertQueryFails consumes ResultSet rows through 
exhaustion, so SQLExceptions raised while fetching later batches propagate into 
the assertion. The result set is closed with try-with-resources; caller scopes 
also close their statements and connections.
   - Corruption regression: the test sets fetch size to 1, asserts that an 
initial row is readable, then drains and checks the later corruption error. The 
JDBC request carries the configured fetch size, and ResultSet.next() requests 
subsequent batches.
   - Assertion-gap audit: reviewed all changed helper and local error-assertion 
paths plus the remaining direct failure checks examined. Those remaining cases 
validate parser, planner, schema, or UDF input errors, or explicitly exercise 
the first result row. No additional delayed-fetch assertion gap was found.
   - Verification: Spotless passed; IoTDBQueryWithCorruptedTsFileIT and 
IoTDBTableAggregationIT passed (65 tests, 0 failures, 0 errors, 0 skipped); 
IoTDBGroupByConditionIT passed (14 tests, 0 failures, 0 errors, 0 skipped); git 
diff --check passed. These runs cover the source content now committed at the 
reviewed head.
   - Not run individually: AINode-specific and other helper-caller ITs. No test 
methods were added in this review round.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to