Caideyipi commented on PR #19323: URL: https://github.com/apache/iotdb/pull/19323#issuecomment-6999607357
Review summary for commit `637382308a23e770ed57ca082651094b7160f6af`, based on `master` at `0002b377a0b059ed890b2635a5a21c649a039a10`: - Finding: the corrupted-TsFile test did not prove the error occurred after an initial successful row. - Fix: set fetch size to 1, assert the first row is readable, then drain and assert the corruption exception. The `drainResultSet` Javadoc now explains that `ResultSet.next()` fetches later batches where execution errors can surface. - Similar-path audit: no further confirmed delayed-fetch assertion gaps. The remaining direct JDBC failure checks inspected are parser, planner, analyzer, or schema-resolution errors. COPY TO path/option checks through the Session API are performed during analysis/parsing. - Verification: Spotless passed; `TableSimpleIT` ran 65 tests and `SimpleIT` ran 14 tests, all with zero failures, errors, or skips; `git diff --check` passed. AINode-specific and remaining helper-caller ITs were not individually run; remote CI was not awaited. - The PR remains Draft pending a fresh independent review of the full updated diff. Local, remote-branch, and PR head SHAs all match `637382308a23e770ed57ca082651094b7160f6af`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
