Caideyipi commented on PR #19323:
URL: https://github.com/apache/iotdb/pull/19323#issuecomment-6998020763

   Initial self-review against `master` at 
`0002b377a0b059ed890b2635a5a21c649a039a10`, covering commit 
`d9e621670ed6bd0f1f4ef6a74efe4655e01fdd27`: no actionable findings; no fixes 
were needed. The reviewed change drains and closes the `ResultSet` in both 
table `tableAssertTestFail` overloads.
   
   Local verification: Spotless completed, and 
`IoTDBTableAggregationIT#exceptionTest` passed (1 test, 0 failures, 0 errors, 0 
skipped) on the reviewed commit.
   
   Scope note: `approx_count_distinct(province, 0.3)` raises its range error 
while generating the initial response; the focused test does not exercise a 
failure that occurs only on a later fetch. The helper also checks SQL errors 
surfaced by later `ResultSet.next()` calls.
   
   Remote checks at review time: Windows (1) and Windows (2) were queued; Sonar 
and Codecov were skipped.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to