Alexey Serbin has posted comments on this change.

Change subject: C++ client: deprecating KuduPartialRow::SetString()
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3723/3//COMMIT_MSG
Commit Message:

Line 21: An alternative approach might be to change behavior of
> I'm personally in favor of this approach.  I think the very temporary downs
I also like that approach (that was the initial idea I had), but after some 
discussion with Todd and Mike in HipChat the Set{String,Binary}Copy() approach 
appeared as the way to go.

Todd, Mike, JD: do you think it's worth reconsidering, making more priority for 
long-term usability side?  Or perf. regression concerns have more priority to 
us at this point?


-- 
To view, visit http://gerrit.cloudera.org:8080/3723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I348b0b9437b8d7928e3b607a0e0610d8d0c58f7c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to