Todd Lipcon has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() ......................................................................
Patch Set 2: (1 comment) Did you want to update the call sites to not use the deprecated function (a couple tests)? http://gerrit.cloudera.org:8080/#/c/3723/2/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: Line 99: // must remain valid until the call to AppendToPB(). nit: AppendToPB isn't a public function, so this doesn't make sense in the public doc. (I see you're just copying this from the existing comment, though, so feel free to fix in some follow-up, since iirc you are planning on doxygenizing (doxygenating?) this file anyway -- To view, visit http://gerrit.cloudera.org:8080/3723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I348b0b9437b8d7928e3b607a0e0610d8d0c58f7c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
