Mike Percy has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() ......................................................................
Patch Set 3: One more thing. If we go forward w/ the deprecation approach then we should add a short unit test that calls the deprecated methods. The compiler warnings on such a test can be squelched on recent versions of GCC (4.2+ I think) and Clang using #pragma GCC diagnostic ignore: http://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-via-pragmas -- To view, visit http://gerrit.cloudera.org:8080/3723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I348b0b9437b8d7928e3b607a0e0610d8d0c58f7c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
