Dan Burkert has posted comments on this change. Change subject: KUDU-1500: Fix the data race during RaftConsensusITest.TestCorruptReplicaMetadata ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3823/2//COMMIT_MSG Commit Message: Line 11: the partition schema is accessed in an unguarded manner from another This is pretty confusing to me, because once a tablet is created, the partition schema and partition are locked; they can not be altered. It sounds like during tablet bootstrap, the in-memory version of these objects is changing, though? Perhaps we shouldn't be doing that. What are the partition and partition schema before they are overwritten? http://gerrit.cloudera.org:8080/#/c/3823/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 177: attrs["partition"] = metadata_->partition_schema().PartitionDebugString( if this is just a formatting change, please leave it the way it was. http://gerrit.cloudera.org:8080/#/c/3823/2/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: Line 207: n_bytes = HumanReadableNumBytes::ToString( same here with only formatting changes. -- To view, visit http://gerrit.cloudera.org:8080/3823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If57617e22b41296b8d4e8ad131220f1ebb235019 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
