Dan Burkert has posted comments on this change.

Change subject: KUDU-1500: Fix the data race during 
RaftConsensusITest.TestCorruptReplicaMetadata
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3823/2/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:

Line 177:     attrs["partition"] = 
metadata_->partition_schema().PartitionDebugString(
> if this is just a formatting change, please leave it the way it was.
By the way, the rule for this particular case is here: 
https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions,
 but more generally we try not to do formatting-only changes as part of other 
commits.


-- 
To view, visit http://gerrit.cloudera.org:8080/3823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If57617e22b41296b8d4e8ad131220f1ebb235019
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to