Todd Lipcon has posted comments on this change. Change subject: [util/monotime] added handy operators for MonoTime ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3999/1/src/kudu/util/monotime.cc File src/kudu/util/monotime.cc: Line 210: DCHECK(delta.nano_delta_ >= 0 || -delta.nano_delta_ <= nanos_); > Yep, will do -- thanks. I explained my motivation for not using it in one I recently switched nanos_ to be a signed integer so that negative monotimes are actually allowed (was necessary for some code in ResultTracker GC to work on systems that had recently booted and thus had low MonoTimes) -- To view, visit http://gerrit.cloudera.org:8080/3999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8a336bc79461adebfb2d5c136d71f90efcd36db Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
