Dinesh Bhat has posted comments on this change.

Change subject: Create base class for MiniCluster and ExternalMiniCluster
......................................................................


Patch Set 5:

(1 comment)

LGTM, one nit below which you can ignore.

http://gerrit.cloudera.org:8080/#/c/3974/5/src/kudu/integration-tests/mini_cluster.h
File src/kudu/integration-tests/mini_cluster.h:

Line 91:   void ShutdownMasters();
Not exactly related to this, but while we are here, perhaps we could just flag 
a bool to Shutdown(bool masters_only) instead of another routine 
ShutDownMasters here.


-- 
To view, visit http://gerrit.cloudera.org:8080/3974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62256168a9245c845e99f7253f07e69a225954bf
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to