Todd Lipcon has posted comments on this change.

Change subject: Create base class for MiniCluster and ExternalMiniCluster
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3974/6/src/kudu/integration-tests/external_mini_cluster.h
File src/kudu/integration-tests/external_mini_cluster.h:

Line 143:   void Shutdown(ClusterNodes nodes) override;
I feel like this is a case where a default argument (ALL) would be nice, since 
99% of the time that's what we want.


http://gerrit.cloudera.org:8080/#/c/3974/6/src/kudu/integration-tests/mini_cluster_base.h
File src/kudu/integration-tests/mini_cluster_base.h:

Line 61:   virtual Status CreateClient(client::KuduClientBuilder* builder,
style: I don't think using a pointer to denote 'optional' is the best. This 
makes it look like the pointer is somehow consumed or an out-param. Why not 
boost::optional here?


-- 
To view, visit http://gerrit.cloudera.org:8080/3974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62256168a9245c845e99f7253f07e69a225954bf
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to