Todd Lipcon has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/3974/5/src/kudu/integration-tests/mini_cluster.h File src/kudu/integration-tests/mini_cluster.h: Line 91: void ShutdownMasters(); > Not exactly related to this, but while we are here, perhaps we could just f Our style usually tries to avoid bool arguments like this, because if you're looking at a call site that says 'Shutdown(true)' you've got no idea what it means without having to break your concentration and go find the docs for the Shutdown method. see also https://google.github.io/styleguide/cppguide.html#Implementation_Comments which has: > Consider changing the function signature to replace a bool argument with an > enum argument. This will make the argument values self-describing. so maybe a Shutdown(WhatToShutdown what); with arguments like MASTERS_ONLY, TABLET_SERVERS_ONLY, and ALL_SERVERS or somesuch would be good Line 157: Status CreateClient(client::KuduClientBuilder& builder, non-const ref arg http://gerrit.cloudera.org:8080/#/c/3974/5/src/kudu/integration-tests/mini_cluster_base.h File src/kudu/integration-tests/mini_cluster_base.h: PS5, Line 18: #ifndef KUDU_INTEGRATION_TESTS_MINI_CLUSTER_BASE_H_ : #define KUDU_INTEGRATION_TESTS_MINI_CLUSTER_BASE_H_ prefer #pragma once now Line 31: class MiniClusterBase { some basic doc would be nice -- To view, visit http://gerrit.cloudera.org:8080/3974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62256168a9245c845e99f7253f07e69a225954bf Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
